Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tauri version #492

Merged
merged 37 commits into from
Nov 12, 2023
Merged

feat: tauri version #492

merged 37 commits into from
Nov 12, 2023

Conversation

sekwah41
Copy link
Member

This is to implement #282

Though needs a lot of clean up atm. Please check out the builds at https://github.com/sekwah41/pomatez/releases/tag/v1.5.0

though I will need to update this all to the right versions and links.

tauri-apps/tauri#3478

As the sounds are triggered by a timer rather than a user interaction the sounds don't work at the moment.

One fix for now if its taking a while to merge would be to trigger the audio in rust. This could be achieved by passing the sound location or reading the data and sending it to rust to play.
@sekwah41 sekwah41 force-pushed the master branch 3 times, most recently from 6670453 to 186d28c Compare November 11, 2023 23:52
@sekwah41 sekwah41 marked this pull request as ready for review November 12, 2023 00:22
Copy link
Member

@roldanjr roldanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, merge it anytime you want @sekwah41. Thank you! 🙇🏼

@sekwah41
Copy link
Member Author

I was going to add a progress bar for downloading though for windows and mac it would have been far too fast to download so I decided against it and added a notification just saying it'll take a moment then install.

@sekwah41
Copy link
Member Author

Looking at the builds, it may be good to rename these to clearly state what platform they are for so that less experienced users do not need to look for the extensions though I will do that in a future update.

Ive got an old MacBook I can test on but it's an old 2012 one. I should have a new MacBook arriving in the next week or two to properly test on so will look to fix most of the issues then.

@sekwah41 sekwah41 merged commit eb175e8 into zidoro:master Nov 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Done
Development

Successfully merging this pull request may close these issues.

2 participants